Initialize only coverlet data collector#2274
Merged
mayankbansal018 merged 1 commit intomicrosoft:masterfrom Dec 16, 2019
Merged
Initialize only coverlet data collector#2274mayankbansal018 merged 1 commit intomicrosoft:masterfrom
mayankbansal018 merged 1 commit intomicrosoft:masterfrom
Conversation
mayankbansal018
approved these changes
Dec 16, 2019
AbhitejJohn
reviewed
Dec 17, 2019
| if (extensions != null && extensions.Any()) | ||
| { | ||
| extensionPaths.AddRange(extensions.Where(x => x.EndsWith(DataCollectorRegexPattern, StringComparison.OrdinalIgnoreCase))); | ||
| extensionPaths.AddRange(extensions.Where(x => x.EndsWith(CoverletDataCollectorRegexPattern, StringComparison.OrdinalIgnoreCase))); |
Contributor
There was a problem hiding this comment.
@vagisha-nidhi : Do we have a work item tracking removal of this hack? We'd want coverlet to add this into the runsettings and not do any special casing, wouldn't we?
Contributor
Author
There was a problem hiding this comment.
I'll create an issue on vstest to clear up all coverlet specialized changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://developercommunity.visualstudio.com/content/problem/738856/could-not-load-file-or-assembly-microsoftintellitr.html
The last fix #2226 did not help because the the data collector extensions (trace data collector) were still being picked up because they were default extensions.
Ideally, https://github.com/microsoft/vstest/blob/master/src/Microsoft.TestPlatform.Common/ExtensionFramework/TestPluginCache.cs#L108 should add default extensions only ending with the given endsWithPattern. At present, its adding all default extensions which even contains data collectors.